> Do the changes fulfil your expectations provided all tests pass?

No because you should catch by const& not by value.  And is "assert(false)" 
really the only/best thing you can do?  Is there any legitimate way the 
position can exceed the size of a long?  If the answer is "yes," then you need 
to do something better.
-- 
https://code.launchpad.net/~zorba-coders/zorba/xml-in-json-indices/+merge/122548
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to