Review: Needs Fixing Looks like you forgot to add xquery.cpp (test case?).
You added the new parse() virtual method to the public API not at the end of the XQuery class. I don't like our XQuery API (what's the point behind creating an XQuery object that doesn't represent a query?), but I guess this new parse() function is consistent with it. But would it be useful to also have a function to retrieve a ModuleInfo from an XQuery that *has* been associated with a query, eg. from Zorba::compileQuery() ? -- https://code.launchpad.net/~zorba-coders/zorba/feature-ModuleInfo/+merge/148616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : email@example.com Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp