Review: Approve

I agree with your logic, Juan; thanks for spelling it out. I hadn't realized 
that your new flag were not checked in the inner loop of fn:subsequence(), but 
looking at the implementation it appears that is the case. So I have no problem 
with it.

Voting Approve now, although clearly the two failing FOTS tests will need to be 
addressed before it will merge.
-- 
https://code.launchpad.net/~zorba-coders/zorba/bug1082740_fn_subsequence/+merge/157755
Your team Zorba Coders is subscribed to branch lp:zorba.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to