Review: Needs Fixing

1. I believe that the correct values for RPATH are directories, not actual .so 
files, so the value of INSTALL_RPATH_PATHS should omit all the "/libjvm.so" 
parts.

2. FindJNI.cmake says:

# (To distribute this file outside of CMake, substitute the full
#  License text for the above reference.)

So, we should do that.
-- 
https://code.launchpad.net/~zorba-coders/zorba/util-jvm-rpath/+merge/163074
Your team Zorba Coders is subscribed to branch lp:zorba/util-jvm-module.

-- 
Mailing list: https://launchpad.net/~zorba-coders
Post to     : zorba-coders@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zorba-coders
More help   : https://help.launchpad.net/ListHelp

Reply via email to