Review: Approve The previous version of the soundex-key function had indeed a problem with the string "3-D Adventure", returning a stack overflow since it as recursively trying to produce a soundex key with just 4 characters. The new implementation fixes this, and also seems to be correct.
I've approved the revision. Nonetheless, it makes no sense to call "soundex-key" with an input that does not correspond to a single English word. Maybe the documentation should be changed in order to indicate this. -- https://code.launchpad.net/~zorba-coders/zorba/fix-soundex_key/+merge/164561 Your team Zorba Coders is subscribed to branch lp:zorba/data-cleaning-module. -- Mailing list: https://launchpad.net/~zorba-coders Post to : firstname.lastname@example.org Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp