Review: Needs Fixing
Looks good! Here are some comments:
- Did you check that the invalid option type error does not exist already? Will
it be consistent also in all other modules?
- Should JSONiq modules not be suffixed as .jq (but it's only cosmetics of
- empty-sequence() -> ()
- array() -> array
- Why remove variadic="true"? I forgot what the semantics for this attribute
- In the implementation of map:key: why not reserve the vector size at the
beginning (unless you cannot get the size of an ItemVector in constant time?).
Your team Zorba Coders is subscribed to branch lp:zorba.
Mailing list: https://launchpad.net/~zorba-coders
Post to : email@example.com
Unsubscribe : https://launchpad.net/~zorba-coders
More help : https://help.launchpad.net/ListHelp