Merged! And thanks again :)
- Marc > On 23 Mar 2018, at 23:41, Kirill Sysoev <[email protected]> wrote: > > Marc, > > What about this part? > https://github.com/zotonic/cowmachine/pull/5 > > Regards, > Kirill > > среда, 21 марта 2018 г., 13:56:37 UTC+3 пользователь Marc Worrell написал: > And merged, thanks! > > - Marc > > >> On 20 Mar 2018, at 18:19, Kirill Sysoev <[email protected] <javascript:>> >> wrote: >> >> Done. >> >> Regards, >> Kirill >> >> вторник, 20 марта 2018 г., 19:40:55 UTC+3 пользователь Marc Worrell написал: >> Yes, please add a merge request! >> >> Thanks, Marc >> >> >>> On 20 Mar 2018, at 17:09, Kirill Sysoev <kirill...@ <>gmail.com >>> <http://gmail.com/>> wrote: >>> >>> Hi, >>> >>> Just noticed, that while rendering "Not Found" error page Zotonic returns >>> code 200 >>> >>> To make a quick workaround a couple of changes needed: >>> >>> https://github.com/onnet/zotonic/commit/b22665dda28d82ae6770a085d645e554cf579032 >>> >>> <https://github.com/onnet/zotonic/commit/b22665dda28d82ae6770a085d645e554cf579032> >>> https://github.com/onnet/cowmachine/commit/73f7db0c3f96a0e32907b5ac5fac565576490ac9 >>> >>> <https://github.com/onnet/cowmachine/commit/73f7db0c3f96a0e32907b5ac5fac565576490ac9> >>> >>> Could it be accepted as a PR or I'm missing something? >>> >>> Regards, >>> Kirill >>> >>> -- >>> >>> --- >>> You received this message because you are subscribed to the Google Groups >>> "Zotonic developers" group. >>> To unsubscribe from this group and stop receiving emails from it, send an >>> email to [email protected] <>. >>> For more options, visit https://groups.google.com/d/optout >>> <https://groups.google.com/d/optout>. >> >> >> -- >> >> --- >> You received this message because you are subscribed to the Google Groups >> "Zotonic developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout >> <https://groups.google.com/d/optout>. > > > -- > > --- > You received this message because you are subscribed to the Google Groups > "Zotonic developers" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected] > <mailto:[email protected]>. > For more options, visit https://groups.google.com/d/optout > <https://groups.google.com/d/optout>. -- --- You received this message because you are subscribed to the Google Groups "Zotonic developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
