https://bugzilla.novell.com/show_bug.cgi?id=350017

User [EMAIL PROTECTED] added comment
https://bugzilla.novell.com/show_bug.cgi?id=350017#c11


Thomas Renninger <[EMAIL PROTECTED]> changed:

           What    |Removed                                         |Added
----------------------------------------------------------------------------
                 CC|                                                |[EMAIL 
PROTECTED]
             Status|ASSIGNED                                        |NEEDINFO
      Info Provider|                                                |[EMAIL 
PROTECTED]




--- Comment #11 from Thomas Renninger <[EMAIL PROTECTED]>  2008-01-14 11:13:51 
MST ---
The problem is this:
+    External (\_PR_.CPU0)
+
     Scope (\_PR)
     {
-        Processor (\_PR.CPU0, 0x00, 0x00000000, 0x00) {}
-        Processor (\_PR.CPU1, 0x01, 0x00000000, 0x00) {}
+        Processor (\_PR.C000, 0x00, 0x00000000, 0x00) {}
+        Processor (\_PR.C001, 0x01, 0x00000000, 0x00) {}
+        Processor (\_PR.C002, 0x02, 0x00000000, 0x00) {}
+        Processor (\_PR.C003, 0x03, 0x00000000, 0x00) {}
     }

But the passive trip point device is still:
            Name (_PSL, Package (0x01)
            {
                \_PR.CPU0
            })

So they changed the name of CPU{0,1} cpu devices to C00{0,1,2,3}
but forgot to change the reference to the passive trip point device.

Someone should tell this ASUS, but I don't have any contacts to them, Stefan
any idea whom we could contact there?

I also wonder why the call to _PSL succeeds when the thermal module is
initialized, tz->trips.passive.flags.valid should be 0?:
       status = acpi_evaluate_reference(tz->device->handle, "_PSL", NULL,
                       &tz->trips.passive.devices);
       if (ACPI_FAILURE(status))
                        tz->trips.passive.flags.valid = 0;


Robert/Len, could you help here, pls.
IMO this should get fixed in drivers/acpi/utils.c:acpi_evaluate_reference(..)
The package which includes an invalid reference should get checked there at the
end.
Then tz->trips.passive.flags.valid == 0
and the user gets the correct hint for the BIOS bug:
       if (!tz->trips.passive.flags.valid)
                 printk(KERN_WARNING PREFIX "Invalid passive threshold\n");


-- 
Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
acpi-bugzilla mailing list
acpi-bugzilla@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/acpi-bugzilla

Reply via email to