----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112533/#review40243 -----------------------------------------------------------
Ship it! correct the issues below (which basically involves just getting rid of Ratings.js) and then push. thanks. activeclient/package/contents/ui/storebrowser/AssetColumn.qml <http://git.reviewboard.kde.org/r/112533/#comment29737> not needed activeclient/package/contents/ui/storebrowser/AssetColumn.qml <http://git.reviewboard.kde.org/r/112533/#comment29736> the ratings var should be a property of ratingsBaloon activeclient/package/contents/ui/storebrowser/AssetColumn.qml <http://git.reviewboard.kde.org/r/112533/#comment29731> instead of rejecting 0 as a value, set the minimum value to 1 activeclient/package/contents/ui/storebrowser/AssetColumn.qml <http://git.reviewboard.kde.org/r/112533/#comment29735> replace with: ratingAttributes[attributeId] = attributeValue; activeclient/package/contents/ui/storebrowser/Ratings.js <http://git.reviewboard.kde.org/r/112533/#comment29732> this becomes unecessary activeclient/package/contents/ui/storebrowser/Ratings.js <http://git.reviewboard.kde.org/r/112533/#comment29733> it's fine to set an attribute more that once. maybe they change their mind. so this can go too .. activeclient/package/contents/ui/storebrowser/Ratings.js <http://git.reviewboard.kde.org/r/112533/#comment29734> move to AssetColumn.qml and then ratings.js can go away. - Aaron J. Seigo On Sept. 16, 2013, 7:02 p.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112533/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2013, 7:02 p.m.) > > > Review request for Bodega. > > > Description > ------- > > This patch implements the ratings feature > > > Diffs > ----- > > activeclient/package/contents/ui/storebrowser/RatingsColumn.qml > PRE-CREATION > activeclient/package/contents/ui/storebrowser/Ratings.js PRE-CREATION > activeclient/package/contents/ui/storebrowser/AssetColumn.qml a678f16 > activeclient/package/contents/ui/settings/ParticipantRatings.qml > PRE-CREATION > activeclient/package/contents/ui/SettingsPage.qml fb46eca > activeclient/src/bodegastore.h 1e5aac5 > activeclient/src/bodegastore.cpp ba9dc27 > lib/bodega/CMakeLists.txt 8d382a7 > lib/bodega/assetjob.h 5aab88c > lib/bodega/assetjob.cpp 5f539cb > lib/bodega/assetoperations.h 7ce7900 > lib/bodega/assetoperations.cpp 9f9c2d5 > lib/bodega/assetratingsjob.h PRE-CREATION > lib/bodega/assetratingsjob.cpp PRE-CREATION > lib/bodega/assetratingsjobmodel.h PRE-CREATION > lib/bodega/assetratingsjobmodel.cpp PRE-CREATION > lib/bodega/globals.h 5ab45da > lib/bodega/participantratingsjob.h PRE-CREATION > lib/bodega/participantratingsjob.cpp PRE-CREATION > lib/bodega/participantratingsjobmodel.h PRE-CREATION > lib/bodega/participantratingsjobmodel.cpp PRE-CREATION > lib/bodega/ratingattributesjob.h PRE-CREATION > lib/bodega/ratingattributesjob.cpp PRE-CREATION > lib/bodega/ratingsmodel_p.h PRE-CREATION > lib/bodega/ratingsmodel_p.cpp PRE-CREATION > lib/bodega/session.h d27d284 > lib/bodega/session.cpp a7c7e94 > lib/bodega/session_p.h ebefb4f > > Diff: http://git.reviewboard.kde.org/r/112533/diff/ > > > Testing > ------- > > check the attached images > > > File Attachments > ---------------- > > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/05/ratings-main.png > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/05/participantratings.png > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/labelsnotcenter.png > > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/delete2.png > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/brokenParticipant.diff > > > http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/participantbroken.png > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Active mailing list Active@kde.org https://mail.kde.org/mailman/listinfo/active