[AMD Official Use Only - General] ----------------- Best Regards, Thomas
-----Original Message----- From: Christian König <ckoenig.leichtzumer...@gmail.com> Sent: Thursday, April 18, 2024 5:01 PM To: Chai, Thomas <yipeng.c...@amd.com>; amd-gfx@lists.freedesktop.org Cc: Chai, Thomas <yipeng.c...@amd.com>; Zhang, Hawking <hawking.zh...@amd.com>; Zhou1, Tao <tao.zh...@amd.com>; Li, Candice <candice...@amd.com>; Wang, Yang(Kevin) <kevinyang.w...@amd.com>; Yang, Stanley <stanley.y...@amd.com> Subject: Re: [PATCH 15/15] drm/amdgpu: Use new interface to reserve bad page Am 18.04.24 um 04:58 schrieb YiPeng Chai: > Use new interface to reserve bad page. > > Signed-off-by: YiPeng Chai <yipeng.c...@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > index d1a2ab944b7d..dee66db10fa2 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c > @@ -2548,9 +2548,7 @@ int amdgpu_ras_add_bad_pages(struct amdgpu_device *adev, > goto out; > } > > - amdgpu_vram_mgr_reserve_range(&adev->mman.vram_mgr, > - bps[i].retired_page << AMDGPU_GPU_PAGE_SHIFT, > - AMDGPU_GPU_PAGE_SIZE); > Were is the call to reserve the VRAM range now moved? [Thomas] Called in amdgpu_ras_reserve_page, amdgpu_ras_reserve_page refer to " [PATCH 01/15] drm/amdgpu: Add interface to reserve bad page " Regards, Christian. > + amdgpu_ras_reserve_page(adev, bps[i].retired_page); > > memcpy(&data->bps[data->count], &bps[i], sizeof(*data->bps)); > data->count++;
