Before you go and follow TreKings excellent suggestion (he beat me to it), you might try in an else clause, setting the visibility to GONE.
I bet you're seeing recycling of the item views. Which underlying item from the LispAdapter a particular View instance is using can change, as they get reused by the ListView to display different items. So my guess is, you're probably setting it when a (id % 5) == 0 item comes up, and not resetting it when an (id % 5) != 0 item is used instead. You may not be realizing this is happening if you're using super.getView(...) to get the view to operate on and return. Still, you should do it TreKing's way. In addition to his excellent reasons, you're violating AdMob's guidelines -- which call for no more than two in the event of a scrolling list, one at the top, one at the bottom of the list. "The number of ads on a single page should not exceed one if the ad is fixed to the screen top or screen bottom. If the page scrolls, there should be a maximum of one ad on the top and one ad on the bottom, and both ads should not appear on the same page." http://helpcenter.admob.com/content/policies-tips-developers-publishers (Admittedly, a bit hard to find -- look for the 'help' link next to your login name on the upper right). I'd say that's really a logical consequence of the following rule (rule #1): "Ads should not be placed close to or underneath buttons or any other object that users may accidentally click while interacting with your app or site." I've seen an app that deliberately violated this. Users noticed, and weren't happy about it. I don't think violating it is a path to maximizing your revenue. You don't want advertising to detract from the value of your app to the user; they'll just stop using it instead. On Feb 8, 12:38 pm, Kasra Rahjerdi <johncena4presid...@gmail.com> wrote: > I had not thought about doing it that way at all. That sounds like a > much better approach than my current method. > > Thank You, > Kasra > > On Feb 8, 11:00 am, TreKing <treking...@gmail.com> wrote: > > > > > On Sun, Feb 7, 2010 at 11:52 PM, Kasra Rahjerdi < > > > johncena4presid...@gmail.com> wrote: > > > The ListView's row > > > layout is a LinearLayout that has two things in it, one AdMob layout > > > and one TextView > > > So EVERY row in your list has an ad but you only want to show every fifth > > one? I assume that is so there's only one ad show on the screen at a time? > > May I suggest you go about this a different way? Use the list view header or > > footer object as the ad or add a completely separate LinearLayout above or > > below the ListView that has the ad. > > > Besides the issues you've described, what happens on a large-screen device > > that shows more than five rows at a time? User gets two or more ads at a > > time. What happens on small-screen device or when switching orientation such > > that the screen height is smaller than normal? You may not display any ads > > at all. > > > Either way seems inconsistent. My $0.02. > > > --------------------------------------------------------------------------- > > ---------------------- > > TreKing - Chicago transit tracking app for Android-powered > > deviceshttp://sites.google.com/site/rezmobileapps/treking -- You received this message because you are subscribed to the Google Groups "Android Developers" group. To post to this group, send email to android-developers@googlegroups.com To unsubscribe from this group, send email to android-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/android-developers?hl=en
