David, Glenn, I have request:
I just found almost 50 patches in Roland's home dir, of which only a
minor fraction appears to be applied in ast-ksh.20120911. I do not
know how or why (Roland is still sick) they were not applied.
Can you please put a small mail reply for each patch send to the list,
so the submitter can track progress, please? It would really help.
Olga
On Sat, Sep 22, 2012 at 12:53 AM, ольга крыжановская
<olga.kryzhanov...@gmail.com> wrote:
> David, I have attached a patch, which cleans up some of the code I and
> Roland changed recently.
>
> Changes:
> - white space changes, where spaces were used, but tabs intended
> - sh_subtmpfile now uses F_dupfd_cloexec, saving one sys call
> - sh_diropenat now takes a bool, instead of int, as xattr parameter
> - sh_diropenat now uses F_dupfd_cloexec, saving a sys call
> - use snprintf instead of sprintf in poll builtin, for security
> - moved b_poll getopts string to data/bltins.c, for clean up
> - error message "Can't obtain directory fd." now uses ERROR_system(1),
> instead of ERROR_exit(1)
> - calling a builtin, with O_SEARCH available, no longer calls stat() 2
> times and then fchdir() if the cwd was moved by the builtin. I found,
> that stat() will make a NFS client call the server each time, while
> just doing the fchdir() does not. It is faster to just do the fchdir()
> for all file systems I tested too, because stat() is slower than
> fchdir(), and 2 stat() are much slower than 1 fchdir()
>
> Olga
> --
> , _ _ ,
> { \/`o;====- Olga Kryzhanovska -====;o`\/ }
> .----'-/`-/ olga.kryzhanov...@gmail.com \-`\-'----.
> `'-..-| / http://twitter.com/fleyta \ |-..-'`
> /\/\ Solaris/BSD//C/C++ programmer /\/\
> `--` `--`
--
, _ _ ,
{ \/`o;====- Olga Kryzhanovska -====;o`\/ }
.----'-/`-/ olga.kryzhanov...@gmail.com \-`\-'----.
`'-..-| / http://twitter.com/fleyta \ |-..-'`
/\/\ Solaris/BSD//C/C++ programmer /\/\
`--` `--`
_______________________________________________
ast-developers mailing list
ast-developers@research.att.com
https://mailman.research.att.com/mailman/listinfo/ast-developers
