----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2947/#review10246 -----------------------------------------------------------
branches/12/include/asterisk/stasis_app.h <https://reviewboard.asterisk.org/r/2947/#comment19594> This should return the enum instead of int. branches/12/include/asterisk/stasis_app.h <https://reviewboard.asterisk.org/r/2947/#comment19593> STASIS_APP_CHANNEL_OK should be explicitly set to 0 since this enum is returned as an int where zero is defined as the non-error code. branches/12/res/ari/resource_bridges.c <https://reviewboard.asterisk.org/r/2947/#comment19586> Change this to: case STASIS_APP_CHANNEL_OK: so that future additions to the enum will cause compilation in dev mode to fail until handling is added. branches/12/res/stasis/control.c <https://reviewboard.asterisk.org/r/2947/#comment19595> This function should be defined to return the enum and others in the calls leading here may need to be changed as well. branches/12/res/stasis/control.c <https://reviewboard.asterisk.org/r/2947/#comment19589> No need for res here. - opticron On Nov. 15, 2013, 1:41 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/2947/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2013, 1:41 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-22624 > https://issues.asterisk.org/jira/browse/ASTERISK-22624 > > > Repository: Asterisk > > > Description > ------- > > Added a channel recording flag that is checked before adding a channel to a > bridge. If the the channel is currently being recorded a "409 Conflict" is > returned and the channel is not added to the bridge. > > > Diffs > ----- > > branches/12/rest-api/api-docs/bridges.json 402853 > branches/12/res/stasis/control.c 402853 > branches/12/res/stasis/command.c 402853 > branches/12/res/stasis/command.h 402853 > branches/12/res/res_stasis_recording.c 402853 > branches/12/res/res_stasis_playback.c 402853 > branches/12/res/res_stasis_answer.c 402853 > branches/12/res/res_ari_bridges.c 402853 > branches/12/res/ari/resource_bridges.c 402853 > branches/12/include/asterisk/stasis_app_impl.h 402853 > branches/12/include/asterisk/stasis_app.h 402853 > > Diff: https://reviewboard.asterisk.org/r/2947/diff/ > > > Testing > ------- > > Ran a manual test and also wrote a testsuite test: > https://reviewboard.asterisk.org/r/2951/ > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
