----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104/#review10710 -----------------------------------------------------------
Ship it! branches/12/res/res_pjsip_endpoint_identifier_ip.c <https://reviewboard.asterisk.org/r/3104/#comment20213> This could use a check before usage. ast_str_create isn't on the stack, and could technically fail. - Matt Jordan On Jan. 16, 2014, 12:04 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3104/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 12:04 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Adds identify, transport and registration support to the CLI. > Creates 3 additional callbacks, one for an iterator, one for a comparator and > one for a container. This eliminates the link dependency from higher level > modules to lower level ones. > Eliminates duplicate sorting. > Cleans up output formatting. > Pushes cli registration down to the implementing source file. > Adds several ast_sip_destroy_sorcery functions to complement existing > ast_sip_sorcery_initialize functions. The destroy functions unregister cli > commands and cli formatters. > > > Diffs > ----- > > branches/12/res/res_pjsip_outbound_registration.c 405643 > branches/12/res/res_pjsip_endpoint_identifier_ip.c 405643 > branches/12/res/res_pjsip/pjsip_options.c 405643 > branches/12/res/res_pjsip/pjsip_configuration.c 405643 > branches/12/res/res_pjsip/pjsip_cli.c 405643 > branches/12/res/res_pjsip/location.c 405643 > branches/12/res/res_pjsip/include/res_pjsip_private.h 405643 > branches/12/res/res_pjsip/config_transport.c 405643 > branches/12/res/res_pjsip/config_global.c 405643 > branches/12/res/res_pjsip/config_domain_aliases.c 405643 > branches/12/res/res_pjsip/config_auth.c 405643 > branches/12/include/asterisk/res_pjsip_cli.h 405643 > branches/12/include/asterisk/res_pjsip.h 405643 > > Diff: https://reviewboard.asterisk.org/r/3104/diff/ > > > Testing > ------- > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
