> On March 5, 2014, 7:38 p.m., Matt Jordan wrote: > > branches/12/res/res_pjsip_endpoint_identifier_ip.c, lines 364-371 > > <https://reviewboard.asterisk.org/r/3283/diff/1/?file=55030#file55030line364> > > > > Any reason you decided to move initialization of the members of the > > struct to load_module? > > Joshua Colp wrote: > He turned it into an ao2 object due to the removal of the hashtab. The > other option is to create an ao2 object in the registration instead.
Yeah, I think I was hallucinating when I made this comment. Drop please :-) - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3283/#review11082 ----------------------------------------------------------- On March 2, 2014, 6:26 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3283/ > ----------------------------------------------------------- > > (Updated March 2, 2014, 6:26 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23276 > https://issues.asterisk.org/jira/browse/ASTERISK-23276 > > > Repository: Asterisk > > > Description > ------- > > Created the 'pjsip show channel' and 'pjsip show contact' commands. > Refactored out the hated ast_hashtab. Replaced with ao2_container. > Cleaned up function naming. Internal only, no public name changes. > Cleaned up whitespace and brace formatting in cli code. > Changed some NULL checking from "if"s to ast_asserts. > Fixed some register/unregister ordering to reduce deadlock potential. > Fixed a bug in ast_sip_location_add_contact where the 'name' buffer was too > short. > Fixed some self-assignment issues in res_pjsip_outbound_registration related > to AMI. > > > Diffs > ----- > > branches/12/res/res_pjsip_outbound_registration.c 409358 > branches/12/res/res_pjsip_endpoint_identifier_ip.c 409358 > branches/12/res/res_pjsip/pjsip_configuration.c 409358 > branches/12/res/res_pjsip/pjsip_cli.c 409358 > branches/12/res/res_pjsip/location.c 409358 > branches/12/res/res_pjsip/config_transport.c 409358 > branches/12/res/res_pjsip/config_auth.c 409358 > branches/12/main/sorcery.c 409358 > branches/12/include/asterisk/sorcery.h 409358 > branches/12/include/asterisk/res_pjsip_cli.h 409358 > > Diff: https://reviewboard.asterisk.org/r/3283/diff/ > > > Testing > ------- > > Ran all 'pjsip show' and 'pjsip list' commands to make sure the output was > correct. > Ran testsuite tests/channels/pjsip/ami to make sure the AMI wasn't affected > by the buffer and self-assignment fix. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
