----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3209/#review11211 -----------------------------------------------------------
Per a discussion on #asterisk-dev when this was discarded. I think moving to an ao2 global for this is introducing a potential performance hit for little to no gain for normal users. While the overall goal to have a clean shutdown is a nice one to have without having this in mind when writing something from the start it's hard to change to it without introducing problems, such as this. I think reducing the chance of a crash is "good enough" but if it still presents a problem we may want to think about reverting the original change. - Joshua Colp On March 14, 2014, 6:35 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3209/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 6:35 p.m.) > > > Review request for Asterisk Developers, Corey Farrell and n8ideas. > > > Bugs: ASTERISK-23103 > https://issues.asterisk.org/jira/browse/ASTERISK-23103 > > > Repository: Asterisk > > > Description > ------- > > Alternate method to more safely shutdown interfaces container. Set interface > global to null first to avoid possible race condition, and also double check > interfaces prior to all uses. > > > Diffs > ----- > > /branches/11/main/format.c 410525 > > Diff: https://reviewboard.asterisk.org/r/3209/diff/ > > > Testing > ------- > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
