> On April 3, 2014, 2:24 p.m., Mark Michelson wrote: > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml, > > lines 46-54 > > <https://reviewboard.asterisk.org/r/3407/diff/1/?file=56911#file56911line46> > > > > The comments here contradict what is said in the test description. The > > test description says that Alice transfers Bob to Charlie, but these > > comments say that Bob transfers Alice to Charlie. > > > > Same applies for the second scenario.
I blame my copy & paste for not automatically making the changes. :) - jbigelow ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/#review11484 ----------------------------------------------------------- On April 4, 2014, 5:44 p.m., jbigelow wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3407/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 5:44 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23446 > https://issues.asterisk.org/jira/browse/ASTERISK-23446 > > > Repository: testsuite > > > Description > ------- > > These tests cover nominal caller initiated blind transfer tests using PJSIP. > > Note: All three tests currently fail due to the issues described in > ASTERISK-23501 & ASTERISK-23502. > > Each test ensures the presents and values of the following: > * channel variables SIPREFERREDBYHDR, SIPREFERTOHDR, SIPTRANSFER, and > SIPREFERRINGCONTEXT. > * the BlindTransfer event. > * the 'Referred-By' header in the INVITE sent to Charlie. > > Each test also sets the TRANSFER_CONTEXT channel variable to ensure the > transfer still occurs properly. The 'caller_with_hold' test additionally > requires and checks the MusicOnHoldStart & MusicOnHoldStop events. > > Tests: > * caller_refer_only: Uses PJSua library. Basic blind transfer without a hold > or direct media being performed at any time. Changes were required to the > pjsua_mod.py library to be able to associate pjsua accounts with a specific > pjsua transport. > * caller_direct_media: Uses SIPp. Blind transfer with direct media between > the endpoints before and after the transfer. > * caller_with_hold: Uses SIPp. Blind transfer with putting the callee on hold > before the transfer. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/charlie.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/bob.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/alice.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/extensions.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/charlie.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/bob.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/tests.yaml 4911 > /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4911 > > Diff: https://reviewboard.asterisk.org/r/3407/diff/ > > > Testing > ------- > > * Added a pre-dial handler when dialing charlie to add the Referred-By > header and commented out the header match for the SIPREFERTOHDR channel > variable. This was to mimic a successful pass to validate the test. This was > done for each. > ** Executed tests in a loop 50+ times to ensure stability. > * Reviewed test suite & Asterisk logs. > > > Thanks, > > jbigelow > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
