----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3538/#review11891 -----------------------------------------------------------
/trunk/apps/app_voicemail.c <https://reviewboard.asterisk.org/r/3538/#comment21775> This change avoids the problem you've discovered by completely discarding the maxmsg limit set for the voicemail user. That doesn't feel like the correct solution here. (As an aside, I think your editor is inserting spaces instead of tabs - you may want to review the Coding Guidelines on the wiki) - Matt Jordan On May 13, 2014, 2:30 p.m., Miguel Tavares wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3538/ > ----------------------------------------------------------- > > (Updated May 13, 2014, 2:30 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23713 > https://issues.asterisk.org/jira/browse/ASTERISK-23713 > > > Repository: Asterisk > > > Description > ------- > > Although it doesn't solve the issue 23713 it makes it a lot less likely to > occur. > > Another, maybe better, option might be to find the fist empty voicemail slot > and use it to store the new message. This means changing the logic of how the > messages are handled and as such as to be written and tested with more care. > > A brief description of the problem. Setting the maxmsg to 3 (so vmu->maxmsg = > 3). When the user has 3 messages he/she deletes the first two. In the file > system we would have the files msg0003.wav and msg0003.txt. If a new message > is being delivered then the last_message_index will return 2 and the message > will be left in the slot 3, meaning that the previous msg0003 will be > overwritten. > > > Diffs > ----- > > /trunk/apps/app_voicemail.c 413892 > > Diff: https://reviewboard.asterisk.org/r/3538/diff/ > > > Testing > ------- > > > Thanks, > > Miguel Tavares > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
