> On June 17, 2014, 3:37 p.m., Jonathan Rose wrote: > > You have a lot of instances of trailing whitespace and some of mixed tabs > > and spaces in here that need to be cleaned up per Asterisk coding > > guidelines (https://wiki.asterisk.org/wiki/display/AST/Coding+Guidelines) > > Jonathan Rose wrote: > On reflection, my reviewboard post ordering was out of whack and this is > probably so old that no one is going to update it. This review should > probably be closed.
I am still following and awaiting comments. Even when it is more than three years since I posted my patch. Thank you for the feedback. I will clean up the code next week but is someone going to approve it? - astmiv ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/1152/#review12164 ----------------------------------------------------------- On May 22, 2011, 6:59 a.m., astmiv wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/1152/ > ----------------------------------------------------------- > > (Updated May 22, 2011, 6:59 a.m.) > > > Review request for Asterisk Developers and pitli...@gmail.com. > > > Repository: Asterisk > > > Description > ------- > > This patch will add access to any calendar folder within Exchange 2007 and > 2010. > > The current resource only gives access to the default calendar folder of the > specified user. With this patch it is possible to access any calendar folder > within the system as long as the user has read rights to the folder and its > complete folder path. > > For example: > - Calendar folders below the publicfoldersroot. > - Calendar folders below the user's mailbox outside of his default calendar. > - Calendar folders below the user's default calendar. > - etc.... > > Also did some cleanup for XML schema labeling. They are now all the same. > > > Diffs > ----- > > /trunk/res/res_calendar_ews.c 311843 > /trunk/configs/calendar.conf.sample 311843 > > Diff: https://reviewboard.asterisk.org/r/1152/diff/ > > > Testing > ------- > > Tested the following scenario's: > - Access to default calendar of specified user. (folderbase not specified or > folderbase=calendar) > - Access to shared default calendar of other person. > (mailbox=emailot...@company.com and folderbase not specified or > folderbase=calendar) > - Access to calendar folder, named testfolder1, below default Calendar. > (folderbase=calendar and folderpath=/testfolder1) > - Access to calendar folder, named testfolder2, below a subfolder, named > testfolder3, of the default Calendar. (folderbase=calendar and > folderpath=/testfolder3/testfolder2) > - Access to calendar folder in Public Folders. (folderbase=publicfoldersroot > and folderpath=/meetingroom1) > - Access to calendar folder below a subfolder in Public Folders. > (folderbase=publicfoldersroot and folderpath=/meetingrooms/meetingroom1) > - Access to calendar folder below mailbox of specified user. > (folderbase=msgfolderroot and folderpath=/calendar2) > > > Thanks, > > astmiv > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
