----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3797/#review12948 -----------------------------------------------------------
Ship it! Go ahead and commit this as the code looks good to go. I'll take care of the documentation for it since PJSIPShowEndpoint is lacking enough in reponse documentation so as to be out of the scope of this review. - opticron On July 29, 2014, 3:05 p.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3797/ > ----------------------------------------------------------- > > (Updated July 29, 2014, 3:05 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This adds additional contact-specific output to PJSIPShowEndpoint output. For > each contact bound to an AOR, we print the AOR name, the contact URI, whether > the contact is reachable (or "Untracked" if not qualifying), and the > roundtrip time for qualification attempts. > > > Diffs > ----- > > /trunk/res/res_pjsip/pjsip_options.c 419589 > > Diff: https://reviewboard.asterisk.org/r/3797/diff/ > > > Testing > ------- > > I have created both tracked and untracked contacts and ensured that the > output looked correct for each. > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
