----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3915/#review13109 -----------------------------------------------------------
trunk/main/manager.c <https://reviewboard.asterisk.org/r/3915/#comment23559> This could stand to be increased to 128 as an allow=all can create a string longer than 64. trunk/main/manager.c <https://reviewboard.asterisk.org/r/3915/#comment23561> blank line between variable declaration and cocde for clarity. trunk/main/manager.c <https://reviewboard.asterisk.org/r/3915/#comment23560> ast_channel_connected_effective_id() is a somewhat more expensive operation than ast_channel_connected(). It would be best if the party_id were saved to a local copy rather than repeatedly called. - rmudgett On Aug. 15, 2014, 9:59 a.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3915/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2014, 9:59 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This adds the AllVariables parameter to the Status AMI action such that if > defined and set to "true", all channel variables will be reported in the > subsequent Status event(s). This parameter does not negate the functionality > of the "Variables" parameter so that global variables and dialplan functions > can be requested. > > > Diffs > ----- > > trunk/main/manager.c 420950 > > Diff: https://reviewboard.asterisk.org/r/3915/diff/ > > > Testing > ------- > > Manual testing via netcat and an automated test here: > https://reviewboard.asterisk.org/r/3916/ > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
