----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3923/#review13174 -----------------------------------------------------------
branches/1.8/main/callerid.c <https://reviewboard.asterisk.org/r/3923/#comment23637> Where did the requirement to allow a missing > come from? The previous code required the <> to match. The prevous code was more lenient with the quotes. branches/1.8/tests/test_callerid.c <https://reviewboard.asterisk.org/r/3923/#comment23639> I'd prefer that cid_set[] did not have the same name as the struct. branches/1.8/tests/test_callerid.c <https://reviewboard.asterisk.org/r/3923/#comment23638> AST-158 explicitly needs to be tested for: "\"name <number>\"", "name", "number" I'd prefer that cid_set[] did not have the same name as the struct. - rmudgett On Aug. 25, 2014, 3:50 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3923/ > ----------------------------------------------------------- > > (Updated Aug. 25, 2014, 3:50 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This allows the callerid parsing function to handle malformed input strings > and strings containing escaped and unescaped double quotes. This also adds a > unittest to cover many of the cases where the parsing algorithm previously > failed. > > > Diffs > ----- > > branches/1.8/tests/test_utils.c 421975 > branches/1.8/tests/test_callerid.c PRE-CREATION > branches/1.8/main/utils.c 421975 > branches/1.8/main/callerid.c 421975 > branches/1.8/include/asterisk/utils.h 421975 > branches/1.8/channels/chan_sip.c 421975 > > Diff: https://reviewboard.asterisk.org/r/3923/diff/ > > > Testing > ------- > > Ran the unittest. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
