-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3950/#review13190
-----------------------------------------------------------

Ship it!


Looks ok to me.
Minor nit.


branches/12/apps/app_confbridge.c
<https://reviewboard.asterisk.org/r/3950/#comment23680>

    This probably fits on one line now.


- rmudgett


On Aug. 27, 2014, 11:56 a.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3950/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2014, 11:56 a.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Currently there's no way to tell if a user is an admin or not when receiving 
> the join, leave, mute, unmute and talking events.  This patch adds that 
> capability.
> 
> 
> Diffs
> -----
> 
>   branches/12/apps/confbridge/confbridge_manager.c 422175 
>   branches/12/apps/app_confbridge.c 422175 
> 
> Diff: https://reviewboard.asterisk.org/r/3950/diff/
> 
> 
> Testing
> -------
> 
> Checked that the AMI events had properly set Admin flags.
> 
> All of the 11 eligible TestSuite confbridge tests passed although they don't 
> test for the existence of the new flag yet.  Nothing broke at least.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to