----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4075/#review13506 -----------------------------------------------------------
/branches/13/res/parking/parking_tests.c <https://reviewboard.asterisk.org/r/4075/#comment24025> blank line after declaration to separate it from code. /branches/13/res/parking/parking_tests.c <https://reviewboard.asterisk.org/r/4075/#comment24026> caps is not checked for NULL /branches/13/res/parking/parking_tests.c <https://reviewboard.asterisk.org/r/4075/#comment24027> Why is chan in parentheses? - rmudgett On Oct. 13, 2014, 3:59 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4075/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2014, 3:59 p.m.) > > > Review request for Asterisk Developers and Matt Jordan. > > > Bugs: ASTERISK-24413 > https://issues.asterisk.org/jira/browse/ASTERISK-24413 > > > Repository: Asterisk > > > Description > ------- > > This patch simply follows the suggested fix of specifying the format for test > channels in the same manner as was done for the CDR unit tests. > > > Diffs > ----- > > /branches/13/res/parking/parking_tests.c 425404 > > Diff: https://reviewboard.asterisk.org/r/4075/diff/ > > > Testing > ------- > > Ran tests prior to patch and got assertions. Assertions no longer occurred > with the patch in place. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev