----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/ -----------------------------------------------------------
(Updated Nov. 19, 2014, 6:40 a.m.) Status ------ This change has been marked as submitted. Review request for Asterisk Developers. Changes ------- Committed in revision 428222 Repository: Asterisk Description ------- When enabling SRTP support in PJSIP it is either forced on or disabled. This means that if you specify SRTP but the client does not support it the session will fail. For situations where this guarantee is not required this new functionality can be used to optimistically use SRTP if possible. This has the added benefit of encrypting the media when possible but does not guarantee it. This also fixes an issue where a client may offer SRTP using the normal transport but we reject it. Diffs ----- /trunk/res/res_pjsip_session.c 426078 /trunk/res/res_pjsip_sdp_rtp.c 426078 /trunk/res/res_pjsip/pjsip_configuration.c 426078 /trunk/res/res_pjsip.c 426078 /trunk/include/asterisk/res_pjsip_session.h 426078 /trunk/include/asterisk/res_pjsip.h 426078 /trunk/contrib/ast-db-manage/config/versions/1443687dda65_add_media_encryption_optimistic_to_pjsip.py PRE-CREATION /trunk/configs/samples/pjsip.conf.sample 426078 /trunk/CHANGES 426078 Diff: https://reviewboard.asterisk.org/r/3992/diff/ Testing ------- Used Blink to place calls with optimistic enabled and disabled on the PJSIP side. In Blink I alternated between disabled/mandatory/optional. Confirmed that for each scenario the expected outcome occurred. Blink Asterisk Result Disabled Optimistic Off Failed Disabled Optimistic On Success (Not encrypted) Mandatory Optimistic Off Success (Encrypted) Mandatory Optimistic On Success (Encrypted) Optional Optimistic Off Success (Encrypted) Optional Optimistic On Success (Encrypted) Thanks, Joshua Colp
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev