----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4373/#review14283 -----------------------------------------------------------
/branches/12/main/manager.c <https://reviewboard.asterisk.org/r/4373/#comment24767> I'd remove the return 0; here. None of the other conditional expressions return early, and you have a return 0 at the end of this function already. - Matt Jordan On Jan. 26, 2015, 1:14 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4373/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2015, 1:14 p.m.) > > > Review request for Asterisk Developers and jbigelow. > > > Repository: Asterisk > > > Description > ------- > > ModuleLoad actions give the wrong response when used to reload a module. On > success, it will issue a 'no such module' error instead of a success response > even though the module was reloaded successfully. > > > Diffs > ----- > > /branches/12/main/manager.c 431112 > > Diff: https://reviewboard.asterisk.org/r/4373/diff/ > > > Testing > ------- > > Before Patch: > > Action: ModuleLoad > LoadType: reload > Module: pbx_config.so > > Response: Error > Message: No such module. > > CLI output showed the module was actually reloaded successfully. > > After Patch: > > Action: ModuleLoad > LoadType: reload > Module: pbx_config.so > > Response: Success > Message: Module reloaded. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev