> On Feb. 10, 2015, 12:50 p.m., Joshua Colp wrote: > > branches/13/res/res_pjsip_config_wizard.c, lines 427-430 > > <https://reviewboard.asterisk.org/r/4383/diff/3/?file=71271#file71271line427> > > > > App and data could still be empty after this.
Not to mention that data is not NULL checked. - rmudgett ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/#review14435 ----------------------------------------------------------- On Feb. 4, 2015, 11:31 a.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4383/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 11:31 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Looking at the Super Awesome Company sample reminded me that creating hints > is just plain gruntwork. So you can now have the pjsip conifg wizard > auto-create them for you. > > Specifying 'hint_exten' in the wizard will create 'exten => > <hint_exten>,hint/PJSIP/<wizard_id>' in whatever is specified for > 'hint_context'. > Specifying 'hint_application' in the wizard will create 'exten => > <hint_exten>,1,<hint_application>' in whatever is specified for > 'hint_context'. > > The default for 'hint_context' is the endpoint's context. > There's no default for 'hint_application'. If not specified, no app is added. > There's no default for 'hint_exten'. If not specified, neither the hint > itself nor the application will be created. > > Some may think this is the slippery slope to users.conf but hints are a basic > necessity for phones unlike voicemail, manager, etc that users.conf creates. > > > Diffs > ----- > > branches/13/res/res_pjsip_config_wizard.c 431571 > branches/13/configs/samples/pjsip_wizard.conf.sample 431571 > > Diff: https://reviewboard.asterisk.org/r/4383/diff/ > > > Testing > ------- > > Existing config_wizard testsuite tests pass. > Additional testsuite tests in the works. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
