> On Jan. 27, 2015, 8:34 p.m., Matt Jordan wrote: > > /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 > > <https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42> > > > > I know '=' is the same as '=>', but I (for some reason) still prefer > > '=>' in dialplan. > > > > I'm not sure why. > > Joshua Colp wrote: > I'm the same way. Across the dialplans I've seen they have primarily used > '=>'. If this uses '=' I'd actually expect people to not know it's the same > and question it. > > rnewton wrote: > I've seen both, '=>' may be more common, however if they are the same > then I'd like to go with '=' to encourage future users to use '='. We should > start doing this through all of our configs and examples since the extra > character is unnecessary. > > If users question it, documentation exists on the wiki stating that they > are the same. > > That being said, if there is a lot of hate for '=' then I'm fine with > '=>'. This is a trivial issue that I don't care a lot about. > > Matt Jordan wrote: > I think there's a general consensus that, despite the semantics being > identical, '=>' is preferred for extensions and hints in the dialplan. > > George Joseph wrote: > Why propagate something that does absolutely nothing? It's only going to > cause someone new to Asterisk to ask "Why is it => in extensions.conf and = > everywhere else?". That was my first question when looking at the Asterisk > config files for the first time. > > >
I agree with you George. We have already had issues filed about the confusion: https://issues.asterisk.org/jira/browse/ASTERISK-23032 There may only be one, or no config files that require '=>'. - rnewton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4379/#review14320 ----------------------------------------------------------- On Jan. 27, 2015, 7:15 p.m., rnewton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4379/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2015, 7:15 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > One of things discussed at the last AstriDevCon was better documentation (for > everything!), but in particular, we mentioned needing some example > configurations that pertain to a real-world scenario. That is, as opposed to > the current "sample" files which are sort of all over the place at this point. > > This patch proposes a basic and minimal configuration of Asterisk to satisfy > the requirements for the first phase of Super Awesome Company's > implementation of Asterisk. > > I will submit four separate patches for the first phase, so that we don't > have to review the entire thing all at once. This review is for the first > patch. > > Who is Super Awesome Company? See > https://wiki.asterisk.org/wiki/display/AST/Super+Awesome+Company > > For the first patch, I am attempting to satisfy the below requirements. The > patch does not include a new make target, as I believe Matt Jordan offered to > handle that. > > SAC requires: > > * PJSIP connectivity for all employee desk phones. > * The ability for employees to call one another inside of the office. > * Voicemail boxes for each of the employees. > > "Basic" configuration > > We want SAC to have a clean system. That means: > > * No 'autoload' in modules.conf. Explicitly load a basic configuration. > If SAC doesn't need the module, don't load it. > * Every module loaded should have a configuration file that is > appropriate for it. This includes all the 'core' things that need > configuration. > > pjsip.conf > > * A PJSIP configuration for their desk phones. Assume every endpoint that > is a phone has: > * A voicemail mailbox that they can subscribe to > * A hint for their device > * Note that the PJSIP configuration should adhere to best practices. > That means MAC addresses for device names, etc. > > extensions.conf > > * A safe dialplan for intra-company communication. This should be > templated out so that it is trivial to add additional devices (use pattern > matching/pattern matching hints, etc.) > * Receiving a Busy/Unavailable should result in going to VoiceMail > * A user should be able to dial something and get to their VoiceMailMain > without having to enter in their extension number > * Note that mapping of MAC address endpoints to extension numbers should > be done in some fashion that is easily extensible. > > voicemail.conf > > * Set up mailboxes for every person in SAC. Assign 'default' pins. Create > reasonable basic settings. > * Do not set up e-mail or pager addresses. > > > REVIEW? > > Please, if possible look at this from a few angles: > > * Use the configuration, configure a couple phones and call between them. > Leave voicemails and retrieve them. > * Have I created any security issues? > * Is my dialplan easy to understand? > * Could anything be done more efficiently without making it over-complicated? > * Have I over-complicated anything? > * Are there any critical settings I'm missing from any of the files? > > A couple, more specific questions: > > * We have sample configs in /configs/samples; what directory do we want > these configurations in? (I used /configs/examples for now, but I don't > really like it) > * We have the make target "make samples" for the current samples; what do we > want for these new configs? > > > Diffs > ----- > > /branches/13/configs/examples/super_awesome_company/voicemail.conf > PRE-CREATION > /branches/13/configs/examples/super_awesome_company/pjsip.conf PRE-CREATION > /branches/13/configs/examples/super_awesome_company/musiconhold.conf > PRE-CREATION > /branches/13/configs/examples/super_awesome_company/modules.conf > PRE-CREATION > /branches/13/configs/examples/super_awesome_company/logger.conf > PRE-CREATION > /branches/13/configs/examples/super_awesome_company/indications.conf > PRE-CREATION > /branches/13/configs/examples/super_awesome_company/extensions.conf > PRE-CREATION > /branches/13/configs/examples/super_awesome_company/asterisk.conf > PRE-CREATION > /branches/13/configs/examples/super_awesome_company/README PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4379/diff/ > > > Testing > ------- > > Setup Asterisk with configuration, connected up three phones using the first > three users. Made calls between them all, left voicemails and retrieved them > with all users. Verified MWI working with all phones. > > > Thanks, > > rnewton > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
