----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4435/#review14494 -----------------------------------------------------------
Ship it! Minor preference nit. /trunk/main/asterisk.c <https://reviewboard.asterisk.org/r/4435/#comment25040> I prefer the #if defined(SO_PASSCRED) format as it allows more complicated expressions. - rmudgett On Feb. 19, 2015, 3:43 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4435/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2015, 3:43 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24813 > https://issues.asterisk.org/jira/browse/ASTERISK-24813 > > > Repository: Asterisk > > > Description > ------- > > listener() opens the same code block in two places (#if and #else). This > confuses some folding editors causing it to think that an extra code block > was opened. Folding in 'geany' causes all code after listener() to be folded > as if it were part of that procedure. > > This patch does not change any compiled logic, it just makes it easier for > some editors to parse. > > > Diffs > ----- > > /trunk/main/asterisk.c 431991 > > Diff: https://reviewboard.asterisk.org/r/4435/diff/ > > > Testing > ------- > > Some testsuite runs. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
