-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4450/
-----------------------------------------------------------
(Updated March 3, 2015, 2:47 p.m.)
Review request for Asterisk Developers.
Changes
-------
1st patch revision: addresses issues raised on review, also addresses more bugs
found found during that process: common_startup() was ineffective due to
relative paths stored in struct state, ast_tzset() allowed code paths to
add_notify() without zonelist lock held, and a temporary struct state on stack
rather than heap that should not have been added in add_notify().
(Also, test program revised to more completely exercise the code.)
Bugs: ASTERISK-24739
https://issues.asterisk.org/jira/browse/ASTERISK-24739
Repository: Asterisk
Description
-------
File descriptor leak on kqueue(2) systems (found on OpenBSD 5.5) on
main/stdtime/localtime.c -- TZ data files change watch code within the time
functions. (Issue at https://issues.asterisk.org/jira/browse/ASTERISK-24739.)
Diffs (updated)
-----
tags/11.7.0/main/stdtime/localtime.c 432443
Diff: https://reviewboard.asterisk.org/r/4450/diff/
Testing
-------
Patch initially developed against OpenBSD 5.5 ports package sources, and
Asterisk in use. Subsequently developed test program that can run original or
patched 11.7.0 code.
File Attachments
----------------
localtime.c (11.7.0) test program
https://reviewboard.asterisk.org/media/uploaded/files/2015/02/25/f7a19f2a-4a8a-4aff-b7d6-44a4146c358c__patchtest.tgz
Thanks,
Ed Hynan
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
