----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4437/#review14580 -----------------------------------------------------------
I think you hit on just about everything I asked about, so yay for that. ...that is, except for one thing. I had mentioned about how ast_query_set_get() was a leaky abstraction. After thinking about this a bit more, I've figured out a good compromise for it. What if there were an API call to get the number of queries in a query set? This way, you could write loops like: for (i = 0; i < ast_query_set_num_queries(query_set); ++i) { struct ast_dns_query *query = ast_dns_query_set_get(query_set, i); ...do stuff... } or you could get specific queries from the set by index if you know in advance which you want. What do you think about that? - Mark Michelson On Feb. 23, 2015, 12:25 a.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4437/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2015, 12:25 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > A wiki page is present at: > > https://wiki.asterisk.org/wiki/display/~jcolp/Asterisk+DNS+API > > Which details a new DNS API for Asterisk. This exists as a thin wrapper over > other resolver libraries. The core part provides a common interface and some > additional features, such as NAPTR/SRV parsing and recurring lookups. > Examples are provided which cover the common use cases for the API. > > Some stuff to think about: > > 1. Does this encompass everything we think a low level API should? > 2. Are there any higher level APIs that would be useful to have? > 3. Is the usage intuitive and easy? > 4. Are there other examples which would help? > 5. Do we want resolvers to be actual modules or keep them in-core? > 6. Anything else you think of > > Have at it! > > > Diffs > ----- > > > Diff: https://reviewboard.asterisk.org/r/4437/diff/ > > > Testing > ------- > > I've logically run through the API and examples to ensure they provide what > is needed for the future, to make them as easy as possible to use, and to > ensure higher level APIs can be created. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev