----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4460/#review14605 -----------------------------------------------------------
Logically, this looks sound. Structurally, I agree with Ashley's comments. However, I subscribe to the school of fixing bugs in one commit and making structural improvements in a separate commit if they're not directly related to the bug being fixed (in fact, I would eschew some of the formatting changes you've introduced in this review already). So I'd be okay if this got committed as-is and a separate commit were made after to address Ashley's findings. Or if you'd rather knock it all out in one go, do it that way. - Mark Michelson On March 4, 2015, 5:31 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4460/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 5:31 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24755 > https://issues.asterisk.org/jira/browse/ASTERISK-24755 > > > Repository: Asterisk > > > Description > ------- > > A race condition happened between initiating a transfer and requesting > that a dialog termination be delayed. Occasionally, the transferrer > channels would exit the bridge and hangup before the dialog termination > was requested. > > * Made request dialog termination delay before initiating the transfer > action. If the transfer fails then cancel the delayed dialog termination > request. > > * Made safely get the TRANSFER_CONTEXT channel value while the channel is > locked in refer_incoming_attended_request() and > refer_incoming_blind_request(). The pointer returned by > pbx_builtin_getvar_helper() is only valid while the channel is locked. > > * Made refer_attended_alloc() not create the ao2 object with an unneeded > lock. > > > Diffs > ----- > > /branches/13/res/res_pjsip_session.exports.in 432446 > /branches/13/res/res_pjsip_session.c 432446 > /branches/13/res/res_pjsip_refer.c 432446 > /branches/13/include/asterisk/res_pjsip_session.h 432446 > > Diff: https://reviewboard.asterisk.org/r/4460/diff/ > > > Testing > ------- > > The testsuite tests/channels/pjsip/ tests still pass with the patch. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
