----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4465/#review14623 -----------------------------------------------------------
/trunk/res/res_timing_kqueue.c <https://reviewboard.asterisk.org/r/4465/#comment25180> Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on all kqueue(2) systems. /trunk/res/res_timing_kqueue.c <https://reviewboard.asterisk.org/r/4465/#comment25181> See above. /trunk/res/res_timing_kqueue.c <https://reviewboard.asterisk.org/r/4465/#comment25182> See above. - Ed Hynan On March 9, 2015, 6:21 p.m., Justin T. Gibbs wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4465/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 6:21 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24857 > https://issues.asterisk.org/jira/browse/ASTERISK-24857 > > > Repository: Asterisk > > > Description > ------- > > Update the kqueue timing module to conform to current timer API. > > This fixes issues with using the kqueue timing source on Asterisk 13 > on FreeBSD 10. > > res_timing_kqueue.c: > Remove support for kevent64(). The values used to support Asterisk > timers fit within 32bits and so can be handled on all platforms via > kevent(). > > Provide debug logging for, but do not track, unacked events. This > matches the behavior of all other timer implementations. > > Implement continuous mode by triggering and leaving active, a user > event. This ensures that the file descriptor for the timer returns > immediately from poll(), without placing the load of a high speed > timer on the kernel. > > In kqueue_timer_get_max_rate(), don't overstate the capability of > the timer. On some platforms, UINT_MAX is greater than INTPTR_MAX, > the largest integer type kqueue supports for timers. > > In kqueue_timer_get_event(), assume the caller woke up from poll() > and just return the mode the timer is currently in. This matches > all other timer implementations. > > Adjust the test code now that unacked events are not tracked. > > > Diffs > ----- > > /trunk/res/res_timing_kqueue.c 432637 > > Diff: https://reviewboard.asterisk.org/r/4465/diff/ > > > Testing > ------- > > Asterisk 13.2.0 on FreeBSD 10-stable: "timing test", pjsip incoming/outgoing > calls, voicemail prompts and recordings. All of the above failed without > these changes. > > > Thanks, > > Justin T. Gibbs > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
