Michael L. Young has posted comments on this change. Change subject: Update commit_msg.py output format. ......................................................................
Patch Set 2: Code-Review+1 (2 comments) Everything looks good. https://gerrit.asterisk.org/#/c/6/2/commit_msg.py File commit_msg.py: Line 68: attachments.append(" %s uploaded by %s (license %d)" % (x['filename'], x['author']['name'], licenseid)) One minor thing I noticed when looking at the wiki for commit messages. It looks like "uploaded by" has been replaced with "submitted by"? I didn't realize that had changed until now when reviewing the wiki page. Line 106: f.write("Patches:\n") Just a nit-pick. It would seem (in looking at changes to the wiki page) that "Patches" was intentionally changed to lower case "patches". I guess that is now preferred. I looked at recent commit messages and that appears to be the case. -- To view, visit https://gerrit.asterisk.org/6 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9f3a7adf2ca0d1d38d625fc5ba6922b99fb37f7 Gerrit-PatchSet: 2 Gerrit-Project: repotools Gerrit-Branch: master Gerrit-Owner: Corey Farrell <g...@cfware.com> Gerrit-Reviewer: Michael L. Young <elgueromexic...@gmail.com> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
