Jonathan Rose has posted comments on this change. Change subject: Add a test for PJSIP t38 with authentication based on normal t38 test ......................................................................
Patch Set 1: (2 comments) https://gerrit.asterisk.org/#/c/22/1/tests/fax/pjsip/t38_with_auth/run-test File tests/fax/pjsip/t38_with_auth/run-test: Line 6: > Should you add your name to the authors list? Now that I actually have changes in the code? Sure. Line 26: event_count = 0 > If you aren't using this class as a singleton, you don't need to have these Probably not the best course of action to change anything based on what you see in this file. It was just a direct copy of something slightly modified from something that was written in 2011 before we revamped a bunch of the testsuite stuff. -- To view, visit https://gerrit.asterisk.org/22 To unsubscribe, visit https://gerrit.asterisk.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8fd9683dc1b61e7b1afd2b6ede857921beebb88 Gerrit-PatchSet: 1 Gerrit-Project: testsuite Gerrit-Branch: master Gerrit-Owner: Jonathan Rose <jr...@digium.com> Gerrit-Reviewer: Ashley Sanders <asand...@digium.com> Gerrit-Reviewer: Jonathan Rose <jr...@digium.com> Gerrit-Reviewer: Matt Jordan <mjor...@digium.com> Gerrit-HasComments: Yes -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev