Ashley Sanders has posted comments on this change.

Change subject: stasis: set a channel variable on websocket disconnect error
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/18/2/tests/rest_api/applications/stasisstatus/ari_client.py
File tests/rest_api/applications/stasisstatus/ari_client.py:

Line 270:         resource              --  The resource to use to construct 
the endpoint
        :                                   for the ARI request. (optional)
        :                                   (default None.) If no value is 
provided,
        :                                   resource will automatically be 
generated in
        :                                   the form: 'LOCAL/<app_name>@Acme'.
> To make this more generically useful, I'd have the caller pass in the endpo
Good catch. Yes, I 100% agree with you. This should be refactored to live in 
the builder.


-- 
To view, visit https://gerrit.asterisk.org/18
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f7dadfd429bd30e9f07a531f47884d8c923fc13
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Ashley Sanders <asand...@digium.com>
Gerrit-Reviewer: Ashley Sanders <asand...@digium.com>
Gerrit-Reviewer: Mark Michelson <mmichel...@digium.com>
Gerrit-Reviewer: Matt Jordan <mjor...@digium.com>
Gerrit-HasComments: Yes

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to