> On April 7, 2015, 5:28 p.m., Kevin Harwell wrote: > > /trunk/main/dns_core.c, line 438 > > <https://reviewboard.asterisk.org/r/4598/diff/1/?file=73671#file73671line438> > > > > No value is set on true.
This is intended. See https://gcc.gnu.org/onlinedocs/gcc/Conditionals.html - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4598/#review15092 ----------------------------------------------------------- On April 6, 2015, 10:46 p.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4598/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 10:46 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Josh worked on SRV in one branch, and I worked on NAPTR in a separate branch. > Independently we kept coming to realizations that something that one of us > had developed independently would be needed by the other person. We decided > to simply have copies of common functionality in our branches. After merging, > we would perform a refactor to remove duplication. > > This changeset introduces no new DNS functionality. Instead, it takes some > duplicated code and places them into common areas of the DNS core. > > > Diffs > ----- > > /trunk/tests/test_dns_srv.c 434186 > /trunk/tests/test_dns_naptr.c 434186 > /trunk/main/dns_srv.c 434186 > /trunk/main/dns_naptr.c 434186 > /trunk/main/dns_core.c 434186 > /trunk/include/asterisk/dns_internal.h 434186 > /team/group/dns/main/dns_test.c PRE-CREATION > /team/group/dns/include/asterisk/dns_test.h PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4598/diff/ > > > Testing > ------- > > All DNS unit tests continue to pass. > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
