> On April 7, 2015, 2:55 p.m., Olle E Johansson wrote: > > "global" is used for global variabels. Other CLI commands have "show > > settings" - can't we reuse the same with some extra options for system? > > rmudgett wrote: > Where are you getting global variables from the command? > > "pjsip show global" gives the settings for the pjsip.conf [global] > section. > > The command seems aptly named. > > Olle E Johansson wrote: > "core show global" has for a long time been used to show global > variables. For settings we've used "show settings both in core and in SIP - > maybe other modules. > > If we are going to use "global" for something else, then it will be > confusing. We only have a "global" section previously in the dialplan - in > other modules it's mostly called "general". > > But if you already broke this, I rest my case. Just wanted to point out > that I feel it's strange.
I tend to agree with both opinions, but since consistency is a good thing and doing a quick survey of some other commands most seem to use the "show settings". Also it allowed me to combine the two commands into one: pjsip show settings. - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4597/#review15109 ----------------------------------------------------------- On April 7, 2015, 11:05 a.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4597/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 11:05 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24918 > https://issues.asterisk.org/jira/browse/ASTERISK-24918 > > > Repository: Asterisk > > > Description > ------- > > Added two new CLI commands for res_pjsip global and system configuration > settings: > > pjsip show global > pjsip show system > > > Diffs > ----- > > branches/13/res/res_pjsip/config_system.c 434150 > branches/13/res/res_pjsip/config_global.c 434150 > branches/13/CHANGES 434150 > > Diff: https://reviewboard.asterisk.org/r/4597/diff/ > > > Testing > ------- > > Ran the commands and checked output. Changed some options and reloaded and > made sure global settings changed, but system ones did not. Changed some > settings again and restarted and made sure both global and system changes too > effect. Also removed the sections completely from the pjsip.conf file and > made sure the defaults were shown. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
