On Thu, Nov 9, 2017, at 10:53 AM, Floimair Florian wrote:
> Joshua,
> 
> I'm pretty sure I have found the problem, and actually I'm not the first
> to encounter it.
> The solution is to use OPT_YESNO_T in pjsip_configuration.c instead of
> OPT_BOOL_T for the respective values.
> I had a look in commit b6bd97eea2d which introduced the OPT_YESNO_T type
> and the commit description clearly resembles what I have encountered.
> However changing only the values that I have encountered seems a bit
> short-sighted.
> Therefore I want to clarify beforehand:
> 
> 1.) Shouldn't all configuration values that map to a YESNO-Enum type in
> the database be of the type OPT_YESNO_T in pjsip_configuration.c?

Seems like it, yes.

> 2.) The commit introducing OPT_YESNO_T is included in 14, 15 and master
> but not in 13. Should it be backported?

13 does not have push so I don't think it would really have an impact
there or need to be backported.

-- 
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to