On 08/16/2010 05:47 AM, Loui Chang wrote:
I appreciate your efforts PyroPeter. I have some suggestions though.I recommend you to keep your patches small and focused. Here's a guideline: Each of those bullet points above should be at least one commit. This huge all-in-one patch makes it very hard for me to review, and frankly I don't like to deal with them at all. Try to send debatable patches last - for example I'm not so sure that removing 'next' and 'previous' is a good idea. So that applies when the patch is a matter of opinion. Thanks
Sorry for that, I will try to avoid that in the future.
I am now splitting the commit into smaller ones.
Attached are the first four patches:
0001. 00e497a pkg_search_results: rewrite of page navigation
0002. b65a5a3 pkg_search_results: increase size of links in
page-navigation
0003. df02d42 pkg_search_results: replace blind-table with
floating div's
0004. 76a874a Right-to-left written languages now supported
~~PyroPeter
--
freenode/pyropeter "12:50 - Ich drücke Return."
0001-pkg_search_results-rewrite-of-page-navigation.patch.gz
Description: GNU Zip compressed data
0002-pkg_search_results-increase-size-of-links-in-page-na.patch.gz
Description: GNU Zip compressed data
0003-pkg_search_results-replace-blind-table-with-floating.patch.gz
Description: GNU Zip compressed data
0004-Right-to-left-written-languages-now-supported.patch.gz
Description: GNU Zip compressed data
