-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 [adding the list, which would have been the more appropriate place to send this]
According to Thomas Jahns on 9/4/2009 3:50 AM: > Hi, > > in commit 58a97ecfca0650c90b5dffacd3565c2647f37f0d of the autoconf repository, > you replaced several occurrences of blanks with tabs. > > Unfortunately TAB is not a legal character in Fortran source and one of the > lines affected by your change is part of a Fortran print statement which > therefore does no longer compile with e.g. gfortran -Werror. Thus I wanted to > ask you to apply the attached patch. Thanks for the report (it's especially nice when a bug report comes with a patch, as well as a commit id where the regression was introduced). Shows how little I know about Fortran (and I guess things like this show why AC_FC_FREEFORM is so important in the first place, since modern Fortran has followed the lead of C in its change to allow freeform whitespace). I tweaked your patch to add a comment and quadrigraph to prevent my editor from regressing again, added THANKS, NEWS, and ChangeLog edits, and applied it. - -- Don't work too hard, make some time for fun as well! Eric Blake e...@byu.net -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (Cygwin) Comment: Public key at home.comcast.net/~ericblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkqg/KYACgkQ84KuGfSFAYDKlgCfVZFOzquUw8iO64ow3MkDtd9t 5MQAn155a5T+IHyhs4t1B4ywTF4C/8mD =gEBt -----END PGP SIGNATURE-----
>From 87c5dbd357ea16629300d46c93dc4b8239a01ccf Mon Sep 17 00:00:00 2001 From: Thomas Jahns <jahns@dkrz.de> Date: Fri, 4 Sep 2009 11:48:44 +0200 Subject: [PATCH] Fix illegal tab character in Fortran source. --- lib/autoconf/fortran.m4 | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/lib/autoconf/fortran.m4 b/lib/autoconf/fortran.m4 index 93b5f9d..99e4b6b 100644 --- a/lib/autoconf/fortran.m4 +++ b/lib/autoconf/fortran.m4 @@ -1204,7 +1204,7 @@ do program freeform ! FIXME: how to best confuse non-freeform compilers? print *, 'Hello ', & - 'world.' + 'world.' end], [ac_cv_fc_freeform=$ac_flag; break]) done -- 1.5.6.5