The changes look fine, except _AppEventDispatcher.dispatch(). Should we dispatch the event at all, in case handlerContext hasn't been set (or set to null, which should never happen)? I would say no.
Thanks, Artem On 7/8/2013 6:28 PM, Leonid Romanov wrote:
Hello, Please review a fix for 8020038: [macosx] Incorrect usage of invokeLater() and likes in callbacks called via JNI from AppKit thread, As you aware, recent AppContext usage change in 7u25 exposed a number of AppContext related issues in our code. This particular bug focuses on the incorrect invokeLater() and likes usage on OS X. This issue has been discussed in the following thread: http://mail.openjdk.java.net/pipermail/macosx-port-dev/2013-June/005788.html Bug: http://bugs.sun.com/view_bug.do?bug_id=8020038 (might not be available yet) Webrev: http://cr.openjdk.java.net/~leonidr/8020038/webrev.00/ Thanks, Leonid.
