The error message "Cannot find parent device" was shown for users of
macvtap (on batadv devices) whenever the macvtap was moved to a different
netns. This happens because macvtap doesn't provide

The situation for which this message is printed is actually not an error
but just a warning that the optional sanity check was skipped. So demote
the message from error to warning and adjust the text to better explain
what happened.

Reported-by: Leonardo Mörlein <freif...@irrelefant.net>
Signed-off-by: Sven Eckelmann <s...@narfation.org>
---
 net/batman-adv/hard-interface.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
index cdb6e542..83fb51b6 100644
--- a/net/batman-adv/hard-interface.c
+++ b/net/batman-adv/hard-interface.c
@@ -168,9 +168,9 @@ static bool batadv_is_on_batman_iface(const struct 
net_device *net_dev)
 
        /* recurse over the parent device */
        parent_dev = __dev_get_by_index((struct net *)parent_net, iflink);
-       /* if we got a NULL parent_dev there is something broken.. */
        if (!parent_dev) {
-               pr_err("Cannot find parent device\n");
+               pr_warn("Cannot find parent device. Skipping batadv-on-batadv 
check for %s\n",
+                       net_dev->name);
                return false;
        }
 
-- 
2.30.2

Reply via email to