Hello, On Wednesday 22 April 2009 10:12:30 Mordechai T. Abzug wrote: > On Wed, Apr 22, 2009 at 08:33:51AM +0200, Kern Sibbald wrote: > > I am sorry, but it is not clear what you are doing here, in > > particular why you are adding a maxincinterval and what a "POLL" job > > is. > > I was trying to improve handling for laptops and other devices that go > away for the night.
OK, that puts it in a bit more perspective. > > MaxIncrInterval is intended to be the Incremental analog of > MaxDiffInterval. A "Poll" is a level that doesn't actually do > anything except check if MaxIncrInterval, MaxDiffInterval, or > MaxFullInterval have been exceeded, doing a promotion if necessary. > > The idea is that instead of just running a once-a-night backup that > might fail, one also runs a "poll" job every half hour or so, and sets > MaxIncrInterval to 1 day (or whatever.) If the nightly incremental > fails, when the laptop does show up the next day and the poll runs, > the poll is promoted to an Incremental. If the laptop was there and > got backed up, then the poll doesn't get promoted. OK, I see what you are trying to do. Here are my comments: 1. I had felt that an MaxIncInterval was not necessary, because it is normally an incremental that runs. However, given you want to "poll" more often, I can see the utility of the Directive. 2. Concerning the Poll job: This is very specific, and if we implement something like that, then in two years, we will have 50 different types of Poll jobs that do various things. We currently have an Admin job, which is meant to be used much like you want to do a Poll. I would much rather you look at the current Admin jobs, and extend them to add the same functionality. Since this is a design issue, it is always better to discuss it a bit on the list before starting the implementation. > > While this is intended for laptops, I think it also has a use in 24x7 > server environments, where this is no ideal backup time and spreading > out the backup impact is good. In such an environment, one can set > MaxIncrInterval, MaxDiffInterval, and MaxFullInterval, and *just* run > polls, without explicitly scheduling incrementals, differentials, and > fulls. So if I specify MaxFullInterval of 1 week, and run a full > backup of serverA on Monday and serverB on Tuesday, bacula should > henceforth automatically separate serverA from serverB without me > having to explicitly specify this in the bacula config. Yes, I see the usefulness of what you are implementing, and it should be clear that I would like to put it in. However, I would like you to see if you can do the same thing by extending the existing Admin job without creating another job type. The problem with an Admin is defining the syntax and semantics of how it would check a particular job. Perhaps just a new directive: CheckJobIntervals = <job name> [, <job name> ...] It would check the intervals for the named job(s) and start the appropriate one. Note, the above (Admin jobs and CheckJobIntervals) is just a proposal to be discussed. > > > PS: All patches need to be submitted as attachments to avoid email > > wrapping. > > OK. Patches attached. > One last point, since there is a high probability that we will be using some form of your code, would you go to: www.bacula.org ->FSFE License and fill out the copyright assignment forms and send them into the address indicated? Thanks for your interest in Bacula and your contribution, Kern ------------------------------------------------------------------------------ Stay on top of everything new and different, both inside and around Java (TM) technology - register by April 22, and save $200 on the JavaOne (SM) conference, June 2-5, 2009, San Francisco. 300 plus technical and hands-on sessions. Register today. Use priority code J9JMT32. http://p.sf.net/sfu/p _______________________________________________ Bacula-devel mailing list Bacula-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bacula-devel
