On 10/14/2009 03:06 AM, Michael Buesch wrote: > On Wednesday 14 October 2009 03:25:30 Larry Finger wrote: >> Commit 93bad2b757586fb153ef73b028953a8dcaccde77 entitled "b43: Fix PPC crash >> in rfkill polling on unload" fixed the bug reported in Bugzilla No. 14181; >> however, it introduced a new bug. Whenever the radio switch was turned off, >> it was necessary to unload and reload the driver for it to recognize the >> switch again. >> >> I believe this patch fixes the original problem without introducing any new >> problems. >> >> Signed-off-by: Larry Finger <larry.fin...@lwfinger.net> >> --- >>
John, As Michael correctly points out, this patch substitutes one bug for another. The current bug affects every bcm43xx device with an rfkill switch except BCM4306/3, and the new bug only affects BCM4306/3 users with a kill switch. As the latter group may be the empty set, I think the trade-off is worth it. An additional complication is that I do not have the hardware to test the PPC faults. The OP of Bugzilla #14181 has been helpful; however, if it takes several tries to get a fix, we might miss the 2.6.32 release, which would introduce a significant regression. For the above reasons, I am suggesting that this patch be accepted and pushed to mainline even though it has faults. Thanks, Larry _______________________________________________ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
