On 11/18/2009 01:53 PM, Michael Buesch wrote: > Enforce all device constraints on the descriptor memory region. > > There are several constraints on the descriptor memory, as documented > in the specification. The current code does not enforce them and/or > incorrectly enforces them. > > Those constraints are: > - The address limitations on 30/32bit engines, that also apply to > the skbs. > - The 4k alignment requirement on 30/32bit engines. > - The 8k alignment requirement on 64bit engines. > > Signed-off-by: Michael Buesch <m...@bu3sch.de> > > --- > > It's not entirely clear if any 64bit devices exist that _really_ need the 8k > alignment. However, I think it does not hurt much if we enforce it anyway. > The patch removes the always-set-GFP_DMA-on-64bit-devices hack. The > combination of > the new enforcements should be enough to keep every device happy, including > those > which needed the GFP_DMA hack. The new code will dynamically check if GFP_DMA > is > required, instead of statically doing it all the time. > John, please queue for the next feature release. This patch still needs a fair > amount of testing. I think the best way to get it is to simply apply it. If > this > causes any regressions, we can (temporary) revert it. > > This also is a candidate for a b43legacy backport.
Tested OK for BCM4312 (14e4:4315). I will port/test on b43legacy as I have the hardware. Larry _______________________________________________ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev
