W dniu 5 lutego 2010 22:38 użytkownik Gábor Stefanik <netrolller...@gmail.com> napisał: > 2010/2/5 Rafał Miłecki <zaj...@gmail.com>: >> W dniu 5 lutego 2010 18:34 użytkownik Gábor Stefanik >> <netrolller...@gmail.com> napisał: >>> 2010/2/4 Rafał Miłecki <zaj...@gmail.com>: >>>> Signed-off-by: Rafał Miłecki <zaj...@gmail.com> >>>> --- >>>> drivers/net/wireless/b43/phy_n.c | 4 ++++ >>>> 1 files changed, 4 insertions(+), 0 deletions(-) >>>> >>>> diff --git a/drivers/net/wireless/b43/phy_n.c >>>> b/drivers/net/wireless/b43/phy_n.c >>>> index 074b34c..795bb1e 100644 >>>> --- a/drivers/net/wireless/b43/phy_n.c >>>> +++ b/drivers/net/wireless/b43/phy_n.c >>>> @@ -1069,6 +1069,10 @@ static u16 b43_nphy_gen_load_samples(struct >>>> b43_wldev *dev, u32 freq, u16 max, >>>> } >>>> >>>> samples = kzalloc(len * sizeof(struct b43_c32), GFP_KERNEL); >>>> + if (!samples) { >>>> + b43err(dev->wl, "allocation for samples generation >>>> failed\n"); >>>> + return 0; >>> >>> return -ENOMEM; >> >> Function was somehow designed to return unsigned only. Returning 0 >> means error (see place where we call b43_nphy_gen_load_samples, we >> check result for 0 there. >> >> Is that OK then? > > In that case, OK - I thought this could be passed up to userspace handlers.
Thanks for review :) -- Rafał _______________________________________________ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev