Revision: 17926
http://bibdesk.svn.sourceforge.net/bibdesk/?rev=17926&view=rev
Author: hofman
Date: 2011-06-03 00:05:15 +0000 (Fri, 03 Jun 2011)
Log Message:
-----------
rebuild typeselect search cache lazily
Modified Paths:
--------------
trunk/bibdesk/BDSKTypeSelectHelper.m
Modified: trunk/bibdesk/BDSKTypeSelectHelper.m
===================================================================
--- trunk/bibdesk/BDSKTypeSelectHelper.m 2011-06-03 00:00:23 UTC (rev
17925)
+++ trunk/bibdesk/BDSKTypeSelectHelper.m 2011-06-03 00:05:15 UTC (rev
17926)
@@ -149,10 +149,8 @@
- (void)rebuildTypeSelectSearchCache;
{
- if (searchCache)
- [searchCache release];
-
- searchCache = [[dataSource typeSelectHelperSelectionItems:self] retain];
+ BDSKDESTROY(searchCache);
+ // this will be actually rebuild when we need it
}
- (BOOL)processKeyDownEvent:(NSEvent *)keyEvent;
@@ -262,7 +260,7 @@
- (NSArray *)searchCache;
{
if (searchCache == nil)
- [self rebuildTypeSelectSearchCache];
+ searchCache = [[dataSource typeSelectHelperSelectionItems:self]
retain];
return searchCache;
}
This was sent by the SourceForge.net collaborative development platform, the
world's largest Open Source development site.
------------------------------------------------------------------------------
Simplify data backup and recovery for your virtual environment with vRanger.
Installation's a snap, and flexible recovery options mean your data is safe,
secure and there when you need it. Discover what all the cheering's about.
Get your free trial download today.
http://p.sf.net/sfu/quest-dev2dev2
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit
