Revision: 18057
          http://bibdesk.svn.sourceforge.net/bibdesk/?rev=18057&view=rev
Author:   hofman
Date:     2011-08-10 12:59:03 +0000 (Wed, 10 Aug 2011)

Log Message:
-----------
enumerate keys for KVO rather than explicitly call each one

Modified Paths:
--------------
    trunk/bibdesk/BDSKConditionController.m

Modified: trunk/bibdesk/BDSKConditionController.m
===================================================================
--- trunk/bibdesk/BDSKConditionController.m     2011-08-10 11:21:37 UTC (rev 
18056)
+++ trunk/bibdesk/BDSKConditionController.m     2011-08-10 12:59:03 UTC (rev 
18057)
@@ -337,33 +337,16 @@
 - (void)startObserving {
     BDSKCondition *condition = [self condition];
     [condition addObserver:self forKeyPath:@"key" 
options:NSKeyValueObservingOptionNew | NSKeyValueObservingOptionOld  
context:&BDSKConditionControllerObservationContext];
-    [condition addObserver:self forKeyPath:@"dateComparison" options: 
NSKeyValueObservingOptionOld  
context:&BDSKConditionControllerObservationContext];
-    [condition addObserver:self forKeyPath:@"attachmentComparison" 
options:NSKeyValueObservingOptionOld  
context:&BDSKConditionControllerObservationContext];
-    [condition addObserver:self forKeyPath:@"stringComparison" 
options:NSKeyValueObservingOptionOld  
context:&BDSKConditionControllerObservationContext];
-    [condition addObserver:self forKeyPath:@"stringValue" 
options:NSKeyValueObservingOptionOld  
context:&BDSKConditionControllerObservationContext];
-    [condition addObserver:self forKeyPath:@"countValue" 
options:NSKeyValueObservingOptionOld  
context:&BDSKConditionControllerObservationContext];
-    [condition addObserver:self forKeyPath:@"numberValue" 
options:NSKeyValueObservingOptionOld  
context:&BDSKConditionControllerObservationContext];
-    [condition addObserver:self forKeyPath:@"andNumberValue" 
options:NSKeyValueObservingOptionOld  
context:&BDSKConditionControllerObservationContext];
-    [condition addObserver:self forKeyPath:@"periodValue" 
options:NSKeyValueObservingOptionOld  
context:&BDSKConditionControllerObservationContext];
-    [condition addObserver:self forKeyPath:@"dateValue" 
options:NSKeyValueObservingOptionOld  
context:&BDSKConditionControllerObservationContext];
-    [condition addObserver:self forKeyPath:@"toDateValue" 
options:NSKeyValueObservingOptionOld  
context:&BDSKConditionControllerObservationContext];
+    for (NSString *key in [NSArray arrayWithObjects:@"dateComparison", 
@"attachmentComparison", @"stringComparison", @"stringValue", @"countValue", 
@"numberValue", @"andNumberValue", @"periodValue", @"dateValue", 
@"toDateValue", nil])
+        [condition addObserver:self forKeyPath:key options: 
NSKeyValueObservingOptionOld  
context:&BDSKConditionControllerObservationContext];
     isObserving = YES;
 }
 
 - (void)stopObserving {
     if (isObserving) {
         BDSKCondition *condition = [self condition];
-        [condition removeObserver:self forKeyPath:@"key"];
-        [condition removeObserver:self forKeyPath:@"dateComparison"];
-        [condition removeObserver:self forKeyPath:@"attachmentComparison"];
-        [condition removeObserver:self forKeyPath:@"stringComparison"];
-        [condition removeObserver:self forKeyPath:@"stringValue"];
-        [condition removeObserver:self forKeyPath:@"countValue"];
-        [condition removeObserver:self forKeyPath:@"numberValue"];
-        [condition removeObserver:self forKeyPath:@"andNumberValue"];
-        [condition removeObserver:self forKeyPath:@"periodValue"];
-        [condition removeObserver:self forKeyPath:@"dateValue"];
-        [condition removeObserver:self forKeyPath:@"toDateValue"];
+        for (NSString *key in [NSArray arrayWithObjects:@"key", 
@"dateComparison", @"attachmentComparison", @"stringComparison", 
@"stringValue", @"countValue", @"numberValue", @"andNumberValue", 
@"periodValue", @"dateValue", @"toDateValue", nil])
+            [condition removeObserver:self forKeyPath:key];
         isObserving = NO;
     }
 }


This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.

------------------------------------------------------------------------------
uberSVN's rich system and user administration capabilities and model 
configuration take the hassle out of deploying and managing Subversion and 
the tools developers use with it. Learn more about uberSVN and get a free 
download at:  http://p.sf.net/sfu/wandisco-dev2dev
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to