Revision: 18111
          http://bibdesk.svn.sourceforge.net/bibdesk/?rev=18111&view=rev
Author:   hofman
Date:     2011-09-07 12:11:19 +0000 (Wed, 07 Sep 2011)
Log Message:
-----------
some improvements to code

Modified Paths:
--------------
    trunk/bibdesk/BibDocument.m

Modified: trunk/bibdesk/BibDocument.m
===================================================================
--- trunk/bibdesk/BibDocument.m 2011-09-07 12:03:45 UTC (rev 18110)
+++ trunk/bibdesk/BibDocument.m 2011-09-07 12:11:19 UTC (rev 18111)
@@ -1511,7 +1511,7 @@
     // output the document's macros:
     if(isOK){
         NSString *macroString = [[self macroResolver] bibTeXString];
-        if ([macroString length] > 0) {
+        if ([NSString isEmptyString:macroString] == NO) {
             hasData = YES;
             isOK = [outputData appendDataFromString:macroString 
encoding:encoding error:&error];
             if(NO == isOK)
@@ -1524,10 +1524,10 @@
     NSArray *pubs = [self publicationsForSaving];
     if ([pubs count] > 0) {
         hasData = YES;
-        for (BibItem *pub in [self publicationsForSaving]){
+        for (BibItem *pub in pubs){
             if (isOK == NO) break;
             pubData = [pub bibTeXDataWithOptions:options 
relativeToPath:basePath encoding:encoding error:&error];
-            if(isOK = pubData != nil){
+            if((isOK = (pubData != nil))){
                 [outputData appendData:doubleNewlineData];
                 [outputData appendData:pubData];
             }else if([error valueForKey:NSLocalizedRecoverySuggestionErrorKey] 
== nil)

This was sent by the SourceForge.net collaborative development platform, the 
world's largest Open Source development site.


------------------------------------------------------------------------------
Using storage to extend the benefits of virtualization and iSCSI
Virtualization increases hardware utilization and delivers a new level of
agility. Learn what those decisions are and how to modernize your storage 
and backup environments for virtualization.
http://www.accelacomm.com/jaw/sfnl/114/51434361/
_______________________________________________
Bibdesk-commit mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/bibdesk-commit

Reply via email to